On Fri, 15 Jun 2018 16:04:46 +0200 David Hildenbrand <da...@redhat.com> wrote:
> It is inititally 0, so setting it to 0 should be allowed, too. I'm not sure if we need to permit it. By default labels are disabled (label-size=0) and user are supposed to provide this option if labels should be enabled with a valid size. it could be confusing for user when asking for label and not getting it. I suggest to drop this patch, it's not really related to this series nor required for your future work. > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > hw/mem/nvdimm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c > index db7d8c3050..df7646488b 100644 > --- a/hw/mem/nvdimm.c > +++ b/hw/mem/nvdimm.c > @@ -52,9 +52,9 @@ static void nvdimm_set_label_size(Object *obj, Visitor *v, > const char *name, > if (local_err) { > goto out; > } > - if (value < MIN_NAMESPACE_LABEL_SIZE) { > + if (value && value < MIN_NAMESPACE_LABEL_SIZE) { > error_setg(&local_err, "Property '%s.%s' (0x%" PRIx64 ") is required" > - " at least 0x%lx", object_get_typename(obj), > + " either 0 or at least 0x%lx", object_get_typename(obj), > name, value, MIN_NAMESPACE_LABEL_SIZE); > goto out; > }