Am 04.02.2011 21:19, schrieb Anthony Liguori: > On 02/04/2011 02:01 PM, Stefan Weil wrote: >> Error report from cppcheck: >> block/vdi.c:122: error: Using sizeof for array given as function argument >> returns the size of pointer. >> block/vdi.c:128: error: Using sizeof for array given as function argument >> returns the size of pointer. >> >> Fix both by setting the correct size. >> >> The buggy code is only used when QEMU is build without uuid support. >> The bug is not critical, so there is no urgent need to apply it to >> old versions of QEMU. >> >> Cc: Kevin Wolf<kw...@redhat.com> >> Signed-off-by: Stefan Weil<w...@mail.berlios.de>
Thanks, applied to the block branch. > Huh, I wouldn't have thought this was the case. I almost feel that > doing a #define UUID_SIZE may be better because sizeof(typeof(v)) != > sizeof(v) is weird even by C standards. I think typeof(uu) is actually unsigned char*, not unsigned char[16]. Strange semantics anyway... Kevin
