On 06/20/2018 05:06 AM, Yongbok Kim wrote: > + if (rt == 0 && imm == 0) { > + /* Unconditional branch */ > + } else if (rt == 0 && imm != 0) { > + /* Treat as NOP */ > + goto out;
Given that there is a different unconditional BC opcode, I would expect to never see rt=0 at all. There's no point in special casing it. And it would seem that all of the "goto out" cases miss setting MIPS_HFLAG_FBNSLOT. r~