On 06/26/2018 10:29 AM, Cornelia Huck wrote: [...] >>>> >>>> if (ipl->initrd) { >>>> ram_addr_t initrd_offset; >>>> >>>> would put the command line in no matter what the start address is. >>> >>> I'm for putting that one in (and backporting it to qemu-stable). It's a >>> bit worrying, though, that our ipl code is so fragile... >> >> We actually have to combine this with Thomas fix (to check for rom_ptr >> returning >> something sane). It seems that ipl->commandline is always there, so we have >> to >> check for strlen!=0 it seems.. >> >> I mean if somebody ask for "-append something" we can certainly always write >> something >> if there is rom/ram. > > Given that the uncompressed image is not supposed to be bootable > anymore, does it make sense to add this anyway? I think we can drop this patch for now. > > I'll go ahead and queue Thomas' fix, though. yes, please
- Re: [Qemu-devel] s390 qemu boot failure in -next Christian Borntraeger
- Re: [Qemu-devel] [qemu-s390x] s390 qemu boot fa... Christian Borntraeger
- Re: [Qemu-devel] [qemu-s390x] s390 qemu boo... Cornelia Huck
- Re: [Qemu-devel] [qemu-s390x] s390 qemu boo... Thomas Huth
- Re: [Qemu-devel] s390 qemu boot failure in -nex... Cornelia Huck
- Re: [Qemu-devel] s390 qemu boot failure in ... Christian Borntraeger
- Re: [Qemu-devel] s390 qemu boot failure... Cornelia Huck
- Re: [Qemu-devel] s390 qemu boot fai... Christian Borntraeger
- Re: [Qemu-devel] s390 qemu boot failure in ... Vasily Gorbik
- Re: [Qemu-devel] s390 qemu boot failure... Cornelia Huck
- Re: [Qemu-devel] s390 qemu boot fai... Christian Borntraeger
- Re: [Qemu-devel] s390 qemu boo... Guenter Roeck
- Re: [Qemu-devel] s390 qemu... Vasily Gorbik
- [Qemu-devel] [PATCH] s... Vasily Gorbik
- Re: [Qemu-devel] [PATC... Guenter Roeck
- Re: [Qemu-devel] [PATC... Christian Borntraeger
- Re: [Qemu-devel] [PATC... Cornelia Huck
- Re: [Qemu-devel] s390 qemu boot failure in -nex... Georgi Guninski