On 06/25/2018 09:31 AM, Emilio G. Cota wrote: > + } else if (page1 == page2) { > + page_lock(p1); > + if (ret_p2) { > + *ret_p2 = p1;
I think you should set NULL here... > @@ -1623,7 +1641,7 @@ tb_link_page(TranslationBlock *tb, tb_page_addr_t > phys_pc, > tb = existing_tb; > } > > - if (p2) { > + if (p2 && p2 != p) { > page_unlock(p2); ... so that you need no change here. Otherwise it looks good. r~