On 06/28/2018 01:00 PM, John Snow wrote:
Signed-off-by: John Snow <js...@redhat.com>
---
  tests/qemu-iotests/222     | 149 +++++++++++++++++++++++++++++++++++++++++++++
  tests/qemu-iotests/222.out |  60 ++++++++++++++++++
  tests/qemu-iotests/group   |   1 +
  3 files changed, 210 insertions(+)
  create mode 100644 tests/qemu-iotests/222
  create mode 100644 tests/qemu-iotests/222.out


+
+    log('')
+    log('--- Cleanup ---')
+    log('')
+
+    #log(vm.hmp_qemu_io(srcNode, 'flush'))
+    log(vm.qmp('block-job-cancel', device=srcNode))

Is the commented line still worthwhile to keep?

+    log(vm.qmp('nbd-server-stop'))
+    log(vm.qmp('blockdev-del', node_name=tgtNode))
+    vm.shutdown()
+
+    log('')
+    log('--- Confirming writes ---')
+    log('')
+
+    for p in (overwrite + remainder):
+        cmd = "read -P%s %s %s" % p
+        log(cmd)
+        assert qemu_io_silent(base_img_path, '-c', cmd) == 0
+

Thanks for the additions compared to v1 (including the previously missing .out file ;)
Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to