From: Philippe Mathieu-Daudé <f4...@amsat.org> It eases code review, unit is explicit.
Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Message-Id: <20180625124238.25339-43-f4...@amsat.org> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 0988eb4..61b727a 100644 --- a/monitor.c +++ b/monitor.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/units.h" #include <dirent.h> #include "cpu.h" #include "hw/hw.h" @@ -3288,7 +3289,7 @@ static QDict *monitor_parse_arguments(Monitor *mon, monitor_printf(mon, "enter a positive value\n"); goto fail; } - val <<= 20; + val *= MiB; } qdict_put_int(qdict, key, val); } -- 1.8.3.1