On 2 July 2018 at 16:09, Stafford Horne <sho...@gmail.com> wrote: > Hi Peter, > > Changes since v1: > - Un"fixed" an incorrect checkpatch warning pointed out by Richard. > > Please consider for pull. > > The following changes since commit 646f34fa5482e495483de230b4cf0f2ae4fd2781: > > tcg: Fix --disable-tcg build breakage (2018-07-02 13:42:05 +0100) > > are available in the Git repository at: > > g...@github.com:stffrdhrn/qemu.git tags/pull-or-20180702 > > for you to fetch changes up to 33e1acf437ce4f0b67c262fc93b436e2e306f278: > > target/openrisc: Fix writes to interrupt mask register (2018-07-03 00:05:28 > +0900) > > ---------------------------------------------------------------- > OpenRISC cleanups and Fixes for QEMU 3.0 > > Mostly patches from Richard Henderson fixing multiple things: > * Fix singlestepping in GDB. > * Use more TB linking. > * Fixes to exit TB after updating SPRs to enable registering of state > changes. > * Significant optimizations and refactors to the TLB > * Split out disassembly from translation. > * Add qemu-or1k to qemu-binfmt-conf.sh. > * Implement signal handling for linux-user. > > Then there are a few fixups from me: > * Fix delay slot detections to match hardware, this was masking a bug > in the linus kernel. > * Fix stores to the PIC mask register > > ----------------------------------------------------------------
Compile failure, for the windows crossbuilds: /home/petmay01/qemu-for-merges/target/openrisc/mmu.c: In function 'openrisc_cpu_get_phys_page_debug': /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:133:29: error: 'PROT_EXEC' undeclared (first use in this function) PROT_EXEC | PROT_READ | PROT_WRITE, ^ /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:133:29: note: each undeclared identifier is reported only once for each function it appears in /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:133:41: error: 'PROT_READ' undeclared (first use in this function) PROT_EXEC | PROT_READ | PROT_WRITE, ^ /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:133:53: error: 'PROT_WRITE' undeclared (first use in this function) PROT_EXEC | PROT_READ | PROT_WRITE, ^ /home/petmay01/qemu-for-merges/target/openrisc/mmu.c: In function 'tlb_fill': /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:169:53: error: 'PROT_EXEC' undeclared (first use in this function) int need = (access_type == MMU_INST_FETCH ? PROT_EXEC ^ /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:170:55: error: 'PROT_WRITE' undeclared (first use in this function) : access_type == MMU_DATA_STORE ? PROT_WRITE ^ /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:171:23: error: 'PROT_READ' undeclared (first use in this function) : PROT_READ); ^ /home/petmay01/qemu-for-merges/rules.mak:69: recipe for target 'target/openrisc/mmu.o' failed PROT_READ/WRITE/EXEC are the Posix flags for mmap(). The flags for the 'prot' argument to tlb_set_page() and similar places are PAGE_READ/WRITE/EXEC. PS: for trivial respins of a pullreq you don't need to resend the whole thing, you can just resend the cover letter (and any individual patches which got major changes). thanks -- PMM