Eric Blake <ebl...@redhat.com> writes:
> On 07/02/2018 11:21 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> tests/test-qga.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/tests/test-qga.c b/tests/test-qga.c
>> index 30c9643257..4edd35535d 100644
>> --- a/tests/test-qga.c
>> +++ b/tests/test-qga.c
>> @@ -227,6 +227,22 @@ static void test_qga_ping(gconstpointer fix)
>> qobject_unref(ret);
>> }
>> +static void test_qga_invalid_id(gconstpointer fix)
>> +{
>> + /* FIXME "id" is ignored; it should be rejected */
>
> I might have written:
>
> /* FIXME "id" is ignored; it should either be repeated in the reply,
> or rejected on input */
Sold.
>> + const TestFixture *fixture = fix;
>> + QDict *ret, *val;
>> +
>> + ret = qmp_fd(fixture->fd, "{'execute': 'guest-ping', 'id': 1}");
>> + g_assert_nonnull(ret);
>> + qmp_assert_no_error(ret);
>> +
>> + val = qdict_get_qdict(ret, "return");
>> + g_assert(!qdict_haskey(val, "id"));
>
> This is documenting what currently happens, along with the FIXME
> showing that it is not ideal, so whether or not you improve the
> comment:
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks!
