On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: > > Philippe Mathieu-Daudé <f4...@amsat.org> writes: > > > This silent (since d75402b5ee2): > > > > ./configure > > [...] > > NOTE: cross-compilers enabled: 'cc' > > > > Reported-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Reported-by: Daniel P. Berrangé <berra...@redhat.com> > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index b99ebdde24..fbb53ab6bb 100755 > > --- a/configure > > +++ b/configure > > @@ -7328,7 +7328,7 @@ echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak > > > > done # for target in $targets > > > > -if test -n "$enabled_cross_compilers"; then > > +if test -n "$target_compiler" -a -n "$enabled_cross_compilers"; then > > echo > > echo "NOTE: cross-compilers enabled: $enabled_cross_compilers" > > fi > > I had also added: > > - echo "NOTE: cross-compilers enabled: $enabled_cross_compilers" > + echo "NOTE: compilers enabled for TCG tests: $enabled_cross_compilers"[ > > to make things clearer.
I think we should also 's/NOTE: //', because everything printed by configure at the end is a note. Also get rid of the extra blank line before it. > > Acked-by: Alex Bennée <alex.ben...@linaro.org> > > > -- > Alex Bennée Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
