Re: [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error

[BALATON Zoltan]

On Wed, 4 Jul 2018, Philippe Mathieu-Daudé wrote:
Missed in 3c409c1927e, hopefully reported by Coverity.

Apparently Coverity did report it and Paolo already notified me about 
that. I was about to send a patch but you were faster. Thank you very 
much.

Reviewed-by: BALATON Zoltan <bala...@eik.bme.hu>

Fixes: Coverity CID 1393788 (Copy-paste error)
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
hw/ppc/ppc440_uc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
index 0bbaa6844a..09ccda548f 100644
--- a/hw/ppc/ppc440_uc.c
+++ b/hw/ppc/ppc440_uc.c
@@ -935,7 +935,7 @@ static void dcr_write_dma(void *opaque, int dcrn, uint32_t 
val)
                    if (wptr) {
                        cpu_physical_memory_unmap(wptr, wlen, 1, didx);
                    }
-                    if (wptr) {
+                    if (rptr) {
                        cpu_physical_memory_unmap(rptr, rlen, 0, sidx);
                    }
                }