On Thu, Feb 10, 2011 at 07:23:33PM +0900, Yoshiaki Tamura wrote: > 2011/2/10 Daniel P. Berrange <berra...@redhat.com>: > > On Thu, Feb 10, 2011 at 10:54:01AM +0100, Anthony Liguori wrote: > >> On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: > >> >Currently FdMigrationState doesn't support read(), and this patch > >> >introduces it to get response from the other side. > >> > > >> >Signed-off-by: Yoshiaki Tamura<tamura.yoshi...@lab.ntt.co.jp> > >> > >> Migration is unidirectional. Changing this is fundamental and not > >> something to be done lightly. > > > > Making it bi-directional might break libvirt's save/restore > > to file support which uses migration, passing a unidirectional > > FD for the file. It could also break libvirt's secure tunnelled > > migration support which is currently only expecting to have > > data sent in one direction on the socket. > > Hi Daniel, > > IIUC, this patch isn't something to make existing live migration > bi-directional. Just opens up a way for Kemari to use it. Do > you think it's dangerous for libvirt still?
The key is for it to be a no-op for any usage of the existing 'migrate' command. I had thought this was wiring up read into the event loop too, so it would be poll()ing for reads, but after re-reading I see this isn't the case here. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
