On 5 July 2018 at 17:07, Emilio G. Cota <c...@braap.org> wrote: > This fixes a record-replay regression introduced by 95590e2 > ("translate-all: discard TB when tb_link_page returns an existing > matching TB", 2018-06-15). The problem is that code using CF_NOCACHE > assumes that the TB returned from tb_gen_code is always a > newly-generated one. This assumption, however, was broken in > the aforementioned commit. > > Fix it by honouring CF_NOCACHE, so that tb_gen_code always > returns a newly-generated TB when CF_NOCACHE is passed to it. > Do this by avoiding the TB hash table if CF_NOCACHE is set. > > Reported-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > Tested-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > Signed-off-by: Emilio G. Cota <c...@braap.org> > ---
Applied to master ready for our rc0 tag tomorrow. thanks -- PMM