On Thu, Jul 26, 2018 at 01:10:34PM +0100, Peter Maydell wrote: > On 26 July 2018 at 12:41, Andrew Jones <drjo...@redhat.com> wrote: > > The patch guards the generation. It'll only modify DT and ACPI for the > > new machine type. But, while modifying the DT makes sense, as that > > generated DT will get consumed > > ...will it? Why would we want the firmware to read the > QEMU-generated DT? Real hardware doesn't work that way. >
Good point. If the plan for this reference software is to always prepare its own DTB and ACPI tables, then this patch shouldn't touch the DT generation either. Of course a lot of the device and fdt node creation is intertwined in mach-virt, so it's going to create a DTB anyway. (Unless major refactoring is done first...) Thanks, drew
