On 07/26/2018 05:20 PM, Eric Blake wrote:
On 07/26/2018 05:02 AM, Kevin Wolf wrote:
Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben:
Signed-off-by: Leonid Bloch <lbl...@janustech.com>
---
  docs/qcow2-cache.txt |  3 +++
  qemu-options.hx      | 10 ++++++----
  2 files changed, 9 insertions(+), 4 deletions(-)


+++ b/qemu-options.hx
@@ -752,15 +752,17 @@ image file)
  @item cache-size
  The maximum total size of the L2 table and refcount block caches in bytes
-(default: 1048576 bytes or 8 clusters, whichever is larger)

I think it would be good to still say something about the default.
Maybe something like "default: the sum of l2-cache-size and
refcount-cache-size"?

Except what happens if you specify only one of l2-cache-size or refcount-cache-size? Is the defaulted cache-size then just that one size you specified (and the other cache ignored), or is the total cache size still defaulted to the 1M/8-cluster size (assuming its larger than the other size specified)?

I think that the meaning here is the sum of the actual l2-cache-size and refcount-cache-size. Not the specified options, but the actual caches.

Leonid.

Reply via email to