Le 31/07/2018 à 14:40, Laurent Vivier a écrit : > Le 31/07/2018 à 14:24, no-re...@patchew.org a écrit : >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20180731084203.29959-1-laur...@vivier.eu >> Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> >> BASE=base >> n=1 >> total=$(git log --oneline $BASE.. | wc -l) >> failed=0 >> >> git config --local diff.renamelimit 0 >> git config --local diff.renames True >> git config --local diff.algorithm histogram >> >> commits="$(git log --format=%H --reverse $BASE..)" >> for c in $commits; do >> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." >> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; >> then >> failed=1 >> echo >> fi >> n=$((n+1)) >> done >> >> exit $failed >> === TEST SCRIPT END === >> >> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >> Switched to a new branch 'test' >> 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall >> ba78346662 tests: add check_invalid_maps to test-mmap >> 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly >> >> === OUTPUT BEGIN === >> Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... >> Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... >> ERROR: code indent should never use tabs >> #62: FILE: tests/tcg/multiarch/test-mmap.c:498: >> +^Icheck_invalid_mmaps();$ >> >> total: 1 errors, 0 warnings, 40 lines checked > > I'm going to resend a pull request without the tab.
In fact, no, the whole file uses tabulation. I will not change that. Peter, could you take the series as-is? Thanks, Laurent
