On 07/30/2018 12:12 PM, Aleksandar Markovic wrote:
> case NM_P_GP_BH:
> + {
> + uint32_t u = extract32(ctx->opcode, 0, 18);
> + switch (extract32(ctx->opcode, 18, 3)) {
> + case NM_LBGP:
> + gen_ld(ctx, OPC_LB, rt, 28, u);
> + break;
> + case NM_SBGP:
> + gen_st(ctx, OPC_SB, rt, 28, u);
> + break;
> + case NM_LBUGP:
> + gen_ld(ctx, OPC_LBU, rt, 28, u);
> + break;
> + case NM_ADDIUGP_B:
> + if (rt != 0) {
> + uint32_t offset = extract32(ctx->opcode, 0, 18);
Duplicate extract of U.
Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
