On 26/07/2018 19:17, Alex Bennée wrote: >> + >> +void replay_bh_schedule_oneshot_event(AioContext *ctx, >> + QEMUBHFunc *cb,void *opaque) >> +{ >> + aio_bh_schedule_oneshot(ctx, cb, opaque); >> +} > It seems wrong to have something in stubs that actively does stuff. > Isn't this meant to be a bunch of NOPs?
No, not necessarily, for example int64_t cpu_get_clock(void) { return get_clock_realtime(); } or even void error_vprintf(const char *fmt, va_list ap) { if (g_test_initialized() && !g_test_subprocess() && getenv("QTEST_SILENT_ERRORS")) { char *msg = g_strdup_vprintf(fmt, ap); g_test_message("%s", msg); g_free(msg); } else { vfprintf(stderr, fmt, ap); } } Paolo