Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 1533177743-20894-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1533177743-20894-1-git-send-email-whois.zihan.y...@gmail.com -> patchew/1533177743-20894-1-git-send-email-whois.zihan.y...@gmail.com Switched to a new branch 'test' e2cec939da pci_expander_bridge: add start_bus property 082004294c pci_expander_bridge: Add ioport for pxb host bus 3fed4b00b6 pci_expander_bridge: Add config_read callback bc045b582c i386/acpi-build: describe new pci domain in AML 5dcf56e320 acpi-build: allocate mcfg for pxb-pcie host bridges 61a5c0b2b9 pci_expander_bridge: add type TYPE_PXB_PCIE_HOST === OUTPUT BEGIN === Checking PATCH 1/6: pci_expander_bridge: add type TYPE_PXB_PCIE_HOST... WARNING: line over 80 characters #92: FILE: hw/pci-bridge/pci_expander_bridge.c:156: +static void pxb_pcie_host_get_mmcfg_size(Object *obj, Visitor *v, const char *name, ERROR: space prohibited between function name and open parenthesis '(' #188: FILE: hw/pci-bridge/pci_expander_bridge.c:332: + g_assert (pxb->max_bus >= pxb->bus_nr); WARNING: line over 80 characters #207: FILE: hw/pci-bridge/pci_expander_bridge.c:399: + DEFINE_PROP_UINT16(PROP_PXB_NUMA_NODE, PXBDev, numa_node, NUMA_NODE_UNASSIGNED), WARNING: line over 80 characters #213: FILE: hw/pci-bridge/pci_expander_bridge.c:405: + DEFINE_PROP_UINT16(PROP_PXB_NUMA_NODE, PXBDev, numa_node, NUMA_NODE_UNASSIGNED), total: 1 errors, 3 warnings, 211 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/6: acpi-build: allocate mcfg for pxb-pcie host bridges... ERROR: do not use C99 // comments #34: FILE: hw/i386/acpi-build.c:94: + uint8_t bus_nr; // start bus number ERROR: do not use assignment in if condition #189: FILE: hw/i386/acpi-build.c:2790: + if ((mcfg = acpi_get_mcfg()) != NULL) { ERROR: do not initialise statics to 0 or NULL #278: FILE: hw/pci-bridge/pci_expander_bridge.c:125: +static uint64_t pxb_mcfg_hole_size = 0; WARNING: line over 80 characters #353: FILE: hw/pci-bridge/pci_expander_bridge.c:351: + pxb->domain_nr ? pxb_pcie_mcfg_base : MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT); ERROR: braces {} are necessary for all arms of this statement #357: FILE: hw/pci-bridge/pci_expander_bridge.c:355: + if (pxb->domain_nr) [...] ERROR: braces {} are necessary for all arms of this statement #366: FILE: hw/pci-bridge/pci_expander_bridge.c:468: + if (0 == pxb_pcie_mcfg_base) [...] WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #439: new file mode 100644 total: 5 errors, 2 warnings, 399 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/6: i386/acpi-build: describe new pci domain in AML... ERROR: do not use C99 // comments #28: FILE: hw/i386/acpi-build.c:1879: + i = 1; // PCI0 is q35 host, pxb starts from 1 WARNING: line over 80 characters #111: FILE: hw/i386/acpi-build.c:2168: + aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0C31"))); total: 1 errors, 1 warnings, 112 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/6: pci_expander_bridge: Add config_read callback... ERROR: line over 90 characters #43: FILE: hw/pci-bridge/pci_expander_bridge.c:354: + object_property_add_child(qdev_get_machine(), "pxb-pcie-host[*]", OBJECT(ds), NULL); ERROR: switch and case should be at the same indent #63: FILE: hw/pci-bridge/pci_expander_bridge.c:435: + switch (address) { + case MCH_HOST_BRIDGE_PCIEXBAR: [...] + case MCH_HOST_BRIDGE_PCIEXBAR + 4: [...] + case MCH_HOST_BRIDGE_PCIEXBAR + 8: // Fix me! [...] + default: WARNING: line over 80 characters #67: FILE: hw/pci-bridge/pci_expander_bridge.c:439: + val = object_property_get_uint(host, PCIE_HOST_MCFG_BASE, NULL) & 0xFFFFFFFF; ERROR: line over 90 characters #72: FILE: hw/pci-bridge/pci_expander_bridge.c:444: + val = (object_property_get_uint(host, PCIE_HOST_MCFG_BASE, NULL) >> 32) & 0xFFFFFFFF; ERROR: do not use C99 // comments #74: FILE: hw/pci-bridge/pci_expander_bridge.c:446: + case MCH_HOST_BRIDGE_PCIEXBAR + 8: // Fix me! WARNING: line over 80 characters #77: FILE: hw/pci-bridge/pci_expander_bridge.c:449: + val = object_property_get_uint(host, PCIE_HOST_MCFG_SIZE, NULL) & 0xFFFFFFFF; total: 4 errors, 2 warnings, 106 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/6: pci_expander_bridge: Add ioport for pxb host bus... ERROR: do not use C99 // comments #24: FILE: hw/pci-bridge/pci_expander_bridge.c:234: + // FIX ME! Use specific port number for pxb-pcie host bridge, not scalable! ERROR: line over 90 characters #27: FILE: hw/pci-bridge/pci_expander_bridge.c:237: + sysbus_init_ioports(sbd, PXB_PCIE_HOST_BRIDGE_CONFIG_ADDR_BASE + g_list_length(pxb_dev_list) * 8, 4); ERROR: line over 90 characters #30: FILE: hw/pci-bridge/pci_expander_bridge.c:240: + sysbus_init_ioports(sbd, PXB_PCIE_HOST_BRIDGE_CONFIG_DATA_BASE + g_list_length(pxb_dev_list) * 8, 4); total: 3 errors, 0 warnings, 36 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/6: pci_expander_bridge: add start_bus property... ERROR: do not use C99 // comments #22: FILE: hw/i386/acpi-build.c:94: + uint8_t start_bus; // start bus number WARNING: line over 80 characters #116: FILE: hw/pci-bridge/pci_expander_bridge.c:142: + * as the interval [start_bus, max_bus] has (max_bus-start_bus+1) buses */ ERROR: space prohibited between function name and open parenthesis '(' #141: FILE: hw/pci-bridge/pci_expander_bridge.c:367: + g_assert (pxb->max_bus >= pxb->start_bus); WARNING: line over 80 characters #162: FILE: hw/pci-bridge/pci_expander_bridge.c:394: + qdev_prop_set_uint8(bds, PCI_BRIDGE_DEV_PROP_CHASSIS_NR, pxb->start_bus); total: 2 errors, 2 warnings, 149 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com