On Mon, Aug 6, 2018 at 11:01 AM, Steffen Görtz <cont...@steffen-goertz.de> wrote: > +#define NRF51_TRIGGER_TASK 0x01 > +#define NRF51_EVENT_CLEAR 0x00
Please consider putting these generic constants into hw/arm/nrf51.h or a similar file that all nRF51 devices can include. That way code duplication is eliminated. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>