Hi all. 1. bdrv_dirty_iter_next_area don't use hbitmap_next_zero and uses inefficient loop instead. Let's improve it.
2. bdrv_dirty_iter_next_area don't handle unaligned offset and max_offset correctly. I'm not sure that it is a real bug. But if it is, we need these series in 3.0. Details are in 04 commit message. v2: 01: - improve comment - s/bytes/count/ - fix forgotten function call in test - introduce orig_size field here for HBitmap, make checking in hbitmap_next_zero more effective and safe 02: new 03: - orig_size already introduced in 01 - fix hbitmap_next_dirty_area to not return value less than offset on unaligned requests Vladimir Sementsov-Ogievskiy (7): dirty-bitmap: improve bdrv_dirty_bitmap_next_zero tests: add tests for hbitmap_next_zero with non-zero count parameter dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area block/mirror: fix and improve do_sync_target_write Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area" Revert "test-hbitmap: Add non-advancing iter_next tests" Revert "hbitmap: Add @advance param to hbitmap_iter_next()" include/block/dirty-bitmap.h | 8 +++-- include/qemu/hbitmap.h | 30 ++++++++++++++---- block/backup.c | 4 +-- block/dirty-bitmap.c | 69 +++++++---------------------------------- block/mirror.c | 16 +++++----- nbd/server.c | 2 +- tests/test-hbitmap.c | 69 +++++++++++++++++++++++------------------ util/hbitmap.c | 73 ++++++++++++++++++++++++++++++++++++-------- 8 files changed, 151 insertions(+), 120 deletions(-) -- 2.11.1