On 2018-08-10 18:26, Kevin Wolf wrote: > The block-commit QMP command required specifying the top and base nodes > of the commit jobs using the file name of that node. While this works > in simple cases (local files with absolute paths), the file names > generated for more complicated setups can be hard to predict. > > This adds two new options top-node and base-node to the command, which > allow specifying node names instead. They are mutually exclusive with > the old options. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > qapi/block-core.json | 24 ++++++++++++++++++------ > blockdev.c | 32 ++++++++++++++++++++++++++++++-- > 2 files changed, 48 insertions(+), 8 deletions(-)
Looks good to me, but you made me a bit cautious with your talk of how many pitfalls you've encountered on your way to do this change... Max
signature.asc
Description: OpenPGP digital signature
