On 15 August 2018 at 12:04, Edgar E. Iglesias <edgar.igles...@xilinx.com> wrote: > On Tue, Aug 14, 2018 at 01:42:44PM +0100, Peter Maydell wrote: >> I also noticed that we fail to implement really quite a lot >> of the HCR_EL2 trap semantics for either AArch64 or AArch32, >> to the extent that I'm surprised that nested guests work >> under AArch64 :-) > > Yes, we've have an entry for a while in our TODO list to improve > HCR trapping but haven't gotten around to it. IIRC, at the time > when we where bringing the EL2 stuff up, quite little was actually > being used by KVM/Xen.
We're also I think not correctly implementing some of the required upgrades of TLB maintenance ops to inner-shareable, so I suspect that operation in SMP configs will be flaky. thanks -- PMM