On 08/17/2018 02:04 PM, John Snow wrote:
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for job_completed is kept for now
for use by pre-emptive cancellation.
Signed-off-by: John Snow <js...@redhat.com>
---
@@ -535,7 +535,6 @@ void job_drain(Job *job)
}
}
-
/**
* All jobs must allow a pause point before entering their job proper. This
* ensures that jobs can be paused prior to being started, then resumed later.
Spurious hunk? I'm not opposed to consistent choice of how many newlines
between functions, although it looks a bit odd in the overall patch.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
