Re: [Qemu-devel] [PATCH 03/22] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module

[Richard Henderson]

On 08/20/2018 07:10 AM, Peter Maydell wrote:
> +            if (!(m->control & R_CONTROL_SIZE_MASK)) {
> +                load = deposit32(load, 16, 16, extract32(m->load, 16, 16));
> +            }

The same result, but clearer as

  load = deposit32(m->load, 0, 16, load);

Several instances of this same pattern.

Otherwise,

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~