On Mon, Sep 03, 2018 at 01:24:16PM +0100, Peter Maydell wrote: > On 3 September 2018 at 12:59, Daniel P. Berrangé <berra...@redhat.com> wrote: > > >> ########################################## > >> +# check for usable bpf system call > >> +if test "$bpf" = "yes"; then > > > > if test "x$bpf" != "xno"; then > > We don't use the leading-x thingy elsewhere in configure, > why is this condition special? > (We can assume we don't have a broken shell, and we > know that $bpf won't be a string starting with a hyphen.)
It is just my habit. Drop the 'x' prefix if that's not used in QEMU's configure script normally. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
