Hi Luc,
On 9/1/18 9:46 AM, Luc Michel wrote:
[...]
> +static char *get_thread_id(const GDBState *s, CPUState *cpu,
> + char *buf, size_t buf_size)
To avoid confusion with 'int qemu_get_thread_id()' from "qemu/osdep.h",
can we use another name such gdb_fmt_thread_id() or
get_thread_id_string() or better?
> +{
> + if (s->multiprocess) {
> + snprintf(buf, buf_size, "p%02x.%02x",
> + gdb_get_cpu_pid(s, cpu), cpu_gdb_index(cpu));
> + } else {
> + snprintf(buf, buf_size, "%02x", cpu_gdb_index(cpu));
> +
extra newline ;)
> + }
> +
> + return buf;
> +}
