Emilio G. Cota <c...@braap.org> writes:
> A few fixes since yesterday's v1: > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00884.html > > - Convert copy_qemu_to_soft80 to qemu_to_soft80, just like the other > conversion functions > - Set fp-test as the program name as reported by itself > - Fix Makefile to include .d files so that dependencies are > properly tracked > - Update commit log Just some general comments: - I think this is a better way to go than the IBM test suite - I'm ambivalent about maintaining our fp-test.c in close alignment to softfloat unless we expect much upstreaming of changes. - the coverage seems a bit low. Rebuilding everything with --enable-gcov and running -all1 -all2 I get: tests/fp/fp-test.c - 53.5 % coverage 43.3 % branch coverage fpu/softfloat.c - 32.5 % coverage 25.1 % branch coverage But maybe I didn't pass enough options to fp-test? I could really do with a --just-run-everything-and-summarise-failing-functions option so I can then go through in more detail with fp-test fFOO_BAR. > > Grab this from: > https://github.com/cota/qemu/tree/fp-test-v2 > > Thanks, > > Emilio -- Alex Bennée
