On 7/16/18 6:54 AM, Igor Mammedov wrote:
+
+#include "unistd.h"
+#include "fcntl.h"
+#include "qemu/osdep.h"
+#include "sysemu/numa.h"
+#include "hw/i386/pc.h"
+#include "hw/i386/acpi-build.h"
+#include "hw/acpi/acpi.h"
+#include "hw/acpi/hmat.h"
+#include "hw/acpi/aml-build.h"
+#include "hw/nvram/fw_cfg.h"
+#include "hw/acpi/bios-linker-loader.h"
Do all this headers are really needed here?
Furthermore, "qemu/osdep.h" MUST be listed first (as it may set macros
that affect the content of other headers); "qemu/osdep.h" already takes
care of including <unistd.h> and <fcntl.h>; and even if it hadn't,
system headers should be spelled like <unistd.h> rather than "unistd.h".
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
