Thomas Huth <th...@redhat.com> wrote:
> On 2018-09-13 14:53, Juan Quintela wrote:
>> From: Thomas Huth <th...@redhat.com>
>>
>> We can re-use the s390-ccw bios code to implement a small firmware
>> for a s390x guest which prints out the "A" and "B" characters and
>> modifies the memory, as required for the migration test.
>>
>> Signed-off-by: Thomas Huth <th...@redhat.com>
>> Message-Id: <1535027120-26187-1-git-send-email-th...@redhat.com>
>> Reviewed-by: Juan Quintela <quint...@redhat.com>
>> Acked-by: Cornelia Huck <coh...@redhat.com>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>>
>> +a-b-bios.h: s390x.elf
>> + echo "$$__note" > header.tmp
>> + xxd -i $< | sed -e 's/.*int.*//' >> header.tmp
>> + mv header.tmp $@
>> +
>> +s390x.elf: a-b-bios.c
>> + $(CROSS_PREFIX)gcc $(CFLAGS) -I$(fwdir) $(fwdir)/start.S \
>> + $(fwdir)/sclp.c -o $@ $<
>
> Your modifications look basically fine to me, but please also strip the
> binary after compiling it, so that the header will be quite a bit smaller.
Oops, had it on the s390 and forgot to include it:
$(CROSS_PREFIX)strip --strip-unneded $@
Now sizes are similar.
Thanks, Juan.
