On 13.09.18 14:52, Kevin Wolf wrote: > bdrv_drain_poll_top_level() was buggy because it didn't release the > AioContext lock of the node to be drained before calling aio_poll(). > This way, callbacks called by aio_poll() would possibly take the lock a > second time and run into a deadlock with a nested AIO_WAIT_WHILE() call. > > However, it turns out that the aio_poll() call isn't actually needed any > more. It was introduced in commit 91af091f923, which is effectively > reverted by this patch. The cases it was supposed to fix are now covered > by bdrv_drain_poll(), which waits for block jobs to reach a quiescent > state. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > Reviewed-by: Fam Zheng <f...@redhat.com> > --- > block/io.c | 8 -------- > 1 file changed, 8 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
