On 1 October 2018 at 23:09, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> The TYPE_EMPTY_SLOT and TYPE_UNIMPLEMENTED_DEVICE are identical devices,
> however the later use more recent APIs and is more widely used.
>
> Replace 'empty_slot' by 'unimplemented_device' to simplify devices code
> maintenance.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> @@ -161,7 +161,7 @@ static void niagara_init(MachineState *machine)
> serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> serial_hd(0), DEVICE_BIG_ENDIAN);
> }
> - empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE);
> + create_unimplemented_device("sun4v-iob", NIAGARA_IOBBASE,
> NIAGARA_IOBSIZE);
> sun4v_rtc_init(NIAGARA_RTC_BASE);
> }
Is this actually an unimplemented (missing) device, or are we
implementing hardware-defined "no bus errors when this range is
touched" behaviour ?
thanks
-- PMM
