On Fri, 10/05 10:00, yuchenlin wrote: > Ping? Hi,
This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f. Fam > > On 2018-09-13 16:34, Fam Zheng wrote: > > On Thu, 09/13 16:29, yuchen...@synology.com wrote: > > > From: yuchenlin <yuchen...@synology.com> > > > > > > There is a rare case which the size of last compressed cluster > > > is larger than the cluster size, which will cause the file is > > > not aligned at the sector boundary. > > > > > > There are three reasons to do it. First, if vmdk doesn't align at > > > the sector boundary, there may be many undefined behaviors, > > > such as, in vbox it will show VMDK: Compressed image is corrupted > > > 'syno-vm-disk1.vmdk' (VERR_ZIP_CORRUPTED) when we try to import an > > > ova with unaligned vmdk. Second, all the cluster_sector is aligned > > > to sector, the last one should be like this, too. Third, it ease > > > reading with sector based I/Os. > > > > > > Signed-off-by: yuchenlin <yuchen...@synology.com> > > > > Reviewed-by: Fam Zheng <f...@redhat.com> >
