On Mon, Oct 08, 2018 at 07:31:12PM +0200, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. user_creatable_add_opts_foreach() does that, and then > fails without setting an error. Its caller main(), via > qemu_opts_foreach(), is fine with it, but clean it up anyway. > > Cc: Daniel P. Berrangé <berra...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > qemu-io.c | 8 +++----- > qemu-nbd.c | 8 +++----- > qom/object_interfaces.c | 4 +--- > vl.c | 16 ++++++---------- > 4 files changed, 13 insertions(+), 23 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
