On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > +static bool trans_fcvt_l_s(DisasContext *ctx, arg_fcvt_l_s *a, uint32_t insn) > +{ > +#if defined(TARGET_RISCV64) > + REQUIRE_FPU; > + > + TCGv t0 = tcg_temp_new(); > + gen_set_rm(ctx, a->rm); > + gen_helper_fcvt_l_s(t0, cpu_env, cpu_fpr[a->rs1]); > + gen_set_gpr(a->rd, t0); > + tcg_temp_free(t0); > +#else > + gen_exception_illegal(ctx); > +#endif > + > + return true; > +} > +
Inconsistency among the patches with respect to return false or raising the exception directly. You should probably standardize on one method. Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~