On 25 February 2011 15:32, Blue Swirl <blauwir...@gmail.com> wrote:
> On Wed, Feb 23, 2011 at 5:19 PM, Peter Maydell <peter.mayd...@linaro.org> 
> wrote:
>> +
>> +        if (tcg_check_temp_count()) {
>> +            fprintf(stderr, "TCG temporary leak before %08x\n", dc->pc);
>> +        }
>
> Perhaps this check and tcg_clear_temp_count() calls should be added
> instead to tb_gen_code() in exec.c, to benefit all targets at once. PC
> information will not be as accurate, though.

You'd get a pile of false positives, for instance target-arm doesn't
bother to destroy the whole-TB temporaries like cpu_F0s because there's
no need to. We're trying to check whether the translator could
unboundedly leak temporaries...

-- PMM

Reply via email to