On Wed, Oct 17, 2018 at 10:26:51AM +0200, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. vnc_init_func() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean it up anyway. > > While there, drop a "Failed to start VNC server: " error message > prefix that doesn't really add value. > > Cc: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
