Re: [Qemu-devel] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Python

[Cleber Rosa]

On 10/19/18 3:15 PM, Max Reitz wrote:
> Python 3.4 introduced the inheritable attribute for FDs.  At the same
> time, it changed the default so that all FDs are not inheritable by
> default, that only inheritable FDs are inherited to subprocesses, and
> only if close_fds is explicitly set to False.
> 
> Adhere to this by setting close_fds to False when working with
> subprocesses that may want to inherit FDs, and by trying to
> set_inheritable() on FDs that we do want to bequeath to them.
> 
> Signed-off-by: Max Reitz <mre...@redhat.com>

Reviewed-by: Cleber Rosa <cr...@redhat.com>