On 10/21/18 1:53 PM, Richard Henderson wrote: > On 10/19/18 2:05 AM, Emilio G. Cota wrote: >> To avoid a name clash with the soon-to-be-defined cpu_halted() helper. >> >> Cc: Laurent Vivier <laur...@vivier.eu> >> Signed-off-by: Emilio G. Cota <c...@braap.org> >> --- >> target/m68k/translate.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Although for this usage it's probably better to avoid the > tcg_global_mem_new_i32 and just use tcg_gen_st_i32.
And, as I read further, you need to convert this use to a helper call. Otherwise you've still got an unlocked direct modification to cpu->halted from within the TCG generated code. There are several other targets that do the same thing: alpha, cris, hppa, mips, microblaze, ppc. And typically they will do exactly the same thing: set the flag and then raise the halt exception. r~
