Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

[Philippe Mathieu-Daudé]

On 23/10/18 15:54, Richard Henderson wrote:

On 10/23/18 2:27 PM, Philippe Mathieu-Daudé wrote:

+        if re_fullmatch('!extern', t):
+            extern = True

It looks odd to match a negative form then use a positive one.

Why not simply use 'extern'?

"!" is an escape character here.
Just "escape" would be a field named "escape".

It follows existing similar syntax for !function=foo

Oh OK!

Thanks,

Phil.