On Tue, Mar 1, 2011 at 1:48 AM, Wen Congyang <we...@cn.fujitsu.com> wrote: > This patch fix the following two regressions: > 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(). > 2. The unit of bitmap_intersects()'third parameter is bit, not words. > But we pass the num of words to bitmap_intersects(). > > Changes from v1 to v2: > 1. fix the third argument of bitmap_clear() > > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Seems ok, tested with valgrind this time. But could you re-send this one and the other one at http://patchwork.ozlabs.org/patch/84887/ : - with appropriate Signed-off-by: and changelog for the other patch - using a const size_t width = ds_get_width(vs->ds) / 16; in both patchs to make the call more explicit Thanks, -- Corentin Chary http://xf.iksaif.net
