Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20181103015821.30074-1-lbl...@janustech.com Subject: [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 4b786d4cd6 include: Add a comment to explain the origin of sizes' lookup table === OUTPUT BEGIN === Checking PATCH 1/1: include: Add a comment to explain the origin of sizes' lookup table... ERROR: code indent should never use tabs #43: FILE: include/qemu/units.h:27: + * ^Isuffix="KMGTPE";$ ERROR: code indent should never use tabs #44: FILE: include/qemu/units.h:28: + * ^Ifor(i=10; i<64; i++) {$ ERROR: code indent should never use tabs #45: FILE: include/qemu/units.h:29: + * ^I^Ival=2**i;$ ERROR: code indent should never use tabs #46: FILE: include/qemu/units.h:30: + * ^I^Is=substr(suffix, int(i/10), 1);$ ERROR: code indent should never use tabs #47: FILE: include/qemu/units.h:31: + * ^I^In=2**(i%10);$ ERROR: code indent should never use tabs #48: FILE: include/qemu/units.h:32: + * ^I^Ipad=21-int(log(n)/log(10));$ ERROR: code indent should never use tabs #49: FILE: include/qemu/units.h:33: + * ^I^Iprintf("#define S_%d%siB %*d\n", n, s, pad, val);$ ERROR: code indent should never use tabs #50: FILE: include/qemu/units.h:34: + * ^I}$ total: 8 errors, 0 warnings, 24 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com