On 2 March 2011 22:01, Stefan Weil <w...@mail.berlios.de> wrote: > The part missing in my patch is correct handling of another > rounding effect: > > VNC_DIRTY_WORDS is exact for 32 bit long values (and the > "old" code which used uint32_t until some weeks ago), where > VNC_DIRTY_WORDS = 2560/16/32 = 5. > > For 64 bit values, VNC_DIRTY_WORDS = 2560/16/64 = 2 (rounded)!
Yes, I noticed that after I posted. Given that we have arrays like unsigned long dirty[VNC_MAX_HEIGHT][VNC_DIRTY_WORDS]; rounding down rather than up looks a bit suspicious... (Can we just make VNC_MAX_WIDTH a multiple of 64, or is it baked into the VNC protocol?) -- PMM