Re: [Qemu-devel] [PATCH 2/2] tpm: use loop iterator to set sts data field

[Stefan Berger]

On 11/6/18 12:21 AM, P J P wrote:

From: Prasad J Pandit <p...@fedoraproject.org>

When TIS request is done, set 'sts' data field across all localities.

Signed-off-by: Prasad J Pandit <p...@fedoraproject.org>

Reviewed-by: Stefan Berger <stef...@linux.ibm.com>

---
  hw/tpm/tpm_tis.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 20126dd838..58d90645bc 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -299,7 +299,7 @@ static void tpm_tis_request_completed(TPMIf *ti, int ret)

      if (s->cmd.selftest_done) {
          for (l = 0; l < TPM_TIS_NUM_LOCALITIES; l++) {
-            s->loc[locty].sts |= TPM_TIS_STS_SELFTEST_DONE;
+            s->loc[l].sts |= TPM_TIS_STS_SELFTEST_DONE;
          }
      }