On 06/11/2018 22:23, John Snow wrote: > > > On 11/06/2018 02:46 PM, Paolo Bonzini wrote: >> On 06/11/2018 19:43, Peter Maydell wrote: > >>> hw/ide/ahci.c >> >> Even though AHCIState is not a QOM object, all of its users are >> (TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c). > > Yeah, if there's something *further* that needs to happen, let me know. > I'm not sure what the QOM ideal is.
I think it's okay. The virtio-*-device approach (which is contained in virtio-*-pci and virtio-*-ccw) made sense for virtio where you could have "socket" virtio-mmio devices and the virtio-*-device "plugs" are specified in the command line. However, for AHCI it's overkill. Paolo
