On 9 November 2018 at 15:21, Alex Bennée <alex.ben...@linaro.org> wrote: > The test was incomplete and incorrectly caused debug exceptions to be > generated when returning to EL2 after a failed attempt to single-step > an EL1 instruction. Fix this while cleaning up the function a little.
> @@ -2833,9 +2845,6 @@ static inline bool > aa32_generate_debug_exceptions(CPUARMState *env) > * since the pseudocode has it at all callsites except for the one in > * CheckSoftwareStep(), where it is elided because both branches would > * always return the same value. > - * > - * Parts of the pseudocode relating to EL2 and EL3 are omitted because we > - * don't yet implement those exception levels or their associated trap bits. > */ In hindsight I regret not standardizing on a greppable tag for marking these kinds of "we don't do X because we don't implement feature Y" comments... thanks -- PMM
