On 2018-11-09 14:16, Paolo Bonzini wrote: > On 09/11/2018 13:39, Thomas Huth wrote: >> On 2018-11-09 12:29, Gerd Hoffmann wrote: >>> On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: >>>> Hi, >>>> >>>>> I am also suspicious about hw/bt/ but don't know enough >>>>> about that subsystem to say if it could benefit from >>>>> using QOM objects more. >>>> >>>> I'm wondering whenever anyone would even notice if we just rm -rf hw/bt >>>> >>>> Looking through the changelog for the last five years (after hw/ split) >>>> the only thing I see is fixing warnings from compiler or coverity, >>>> adapting to changes in other systems (chardev for example) and treewide >>>> changes. Not a *single* patch specific to bluetooth ... >>> >>> Tried this after studying docs: >>> >>> qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard >>> >>> Segfaults right anway on first keypress. >>> I guess that qualifies as "broken and obviously unused". >> >> Thanks for checking! I guess that means we could even get rid of it >> without deprecating it first if it is broken already for more than two >> releases...? > > I think what others were using bluetooth passthrough. But it's > certainly possible that it's broken.
Since there haven't been any non-trivial changes to the files in *years*, and apparently none of the current QEMU developers is interested in maintaining this subsystem, I think it is really very likely that it's broken. So unless someone has got some hardware that could be used for testing it, I think we really should mark this as deprecated - we could keep it in that state a little bit longer to see whether a user speaks up and says that it is still useful, but in case nobody uses this anymore, there is really no need that we carry this code with us forever. Thomas
