On Wed, Nov 14, 2018 at 04:36:39PM +0400, Marc-André Lureau wrote: > Do not require QEMU macro.
As with the endian thing, we should really purge ARRAY_SIZE from the entire QEMU codebase and just defer to glib. ARRAY_SIZE made sense before glib was a hard dep in QEMU, but there's no reason beyond bike shed colour choice to preserve it now. I'm fine with this patch being targetted to slirp to avoid getting dragged into a broader discussion, but I'd encourage the global cleanup. I've personally used G_N_ELEMENTS in all QEMU code I've been writing since its more familiar from glib than a QEMU specific macro name. Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
