* Zhang Chen (zhangc...@gmail.com) wrote: > On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell <peter.mayd...@linaro.org> > wrote: > > > On 14 November 2018 at 11:06, Thomas Huth <th...@redhat.com> wrote: > > > On 2018-11-14 11:47, Peter Xu wrote: > > >> On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote: > > >>> This compilation issue will occur when user use --disable-replication > > >>> to config Qemu. > > >>> > > >>> Reported-by: Thomas Huth <th...@redhat.com> > > >>> Signed-off-by: Zhang Chen <zhangc...@gmail.com> > > >> > > >> Hi, > > >> > > >> How's the status of this patch? Are we gonna merge it for 3.1? > > >> > > >> I just posted a similar one without knowing this (until Dave pointed > > >> it out). IMHO it can be a good candidate for 3.1. > > > > > > Maybe Peter Maydell could apply this directly to the repo as a built fix? > > > > I'd rather it just went through the migration tree, really... > > it isn't actually breaking any of our travis jobs or other CI. > > > > > Hi Dave, > > What do you think about peter's comments?
Yep, that's fine, as Peter Xu says, Juan's picking it up for the next one so we should be OK. Dave > Thanks > Zhang Chen > > > > thanks > > -- PMM > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK