On 11/17/18 2:49 PM, Eric Blake wrote:
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
Add tests that validate it is possible to connect to an NBD server
running TLS mode. Also test mis-matched TLS vs non-TLS connections
correctly fail.
---
Missing your Signed-off-by. Can you please supply that, so I can include
this in my pull request?
Also, I'm getting failures when trying to test it:
@@ -17,9 +17,9 @@
== check plain client to TLS server fails ==
option negotiation failed: read failed: Unexpected end-of-file before
all bytes were read
+write failed (error message): Unable to write to socket: Broken pipe
qemu-img: Could not open 'nbd://localhost:10809': TLS negotiation
required before option 8 (structured reply)
server reported: Option 0x8 not permitted before TLS
-write failed (error message): Unable to write to socket: Broken pipe
which looks like an output race. :(
Found and squashed it - commit 37ec36f6 fixed plaintext servers to not
be noisy for NBD_OPT_ABORT, but did not give equal treatment to TLS
servers. Patch coming up separately.
So, with my fixes, I can add:
Tested-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
